Splitting sdk-test out of Test Suite - #5854
Open
JasonAtClockwork wants to merge 16 commits into
Open
Conversation
This was referenced Sep 2, 2026
JasonAtClockwork
marked this pull request as ready for review
September 2, 2026 20:52
JasonAtClockwork
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
September 2, 2026 20:52
Signed-off-by: Jason Larabie <jason@clockworklabs.io>
This reverts commit 73d5940.
joshua-spacetime
left a comment
joshua-spacetime
left a comment
Collaborator
There was a problem hiding this comment.
I'm happy with the current structure. The build times are still rather high for the sdk artifacts, however I think this can be improved with an up-to-date runner image with warmed cache. I also think there are caching improvements we can make for the c++ sdk and modules by baking those compilation units into the runner image. So ultimately I think we can reduce those build times substantially with infra-side changes.
| SDK_TEST_CLIENT_DIR: sdk-test-clients/native | ||
| steps: &sdk-test-partition-steps | ||
| - *set-cargo-target-dir | ||
| - *configure-sccache |
Collaborator
There was a problem hiding this comment.
Do these tests compile anything now?
Comment on lines
-650
to
-653
| INSTALLED_WASM_BINDGEN_VERSION="$(wasm-bindgen --version 2>/dev/null | awk '{print $2}' || true)" | ||
| if [ "${INSTALLED_WASM_BINDGEN_VERSION}" != "${REQUIRED_WASM_BINDGEN_VERSION}" ]; then | ||
| cargo install --locked --force wasm-bindgen-cli --version "${REQUIRED_WASM_BINDGEN_VERSION}" | ||
| fi |
Collaborator
There was a problem hiding this comment.
It looks like this block was removed entirely. Was that intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
First step to #5839 splitting out the SDK tests and partition:
cargo ci sdk-testscommand for local SDK test executionAPI and ABI breaking changes
No breaking changes - only tests
Rollback safety impact
n/a
Expected complexity level and risk
2 - Splitting up requires CI work and mucking with test setup for preparing clients
Testing